From 1682cbc5992ac5a430f7aa4c4e16d1a7797f17b8 Mon Sep 17 00:00:00 2001 From: Akash Yadav Date: Wed, 11 Jan 2023 20:00:25 +0530 Subject: [PATCH] fix(lsp/java): type params not included in generated constructor parameter types --- .../lsp/java/actions/generators/GenerateConstructorAction.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateConstructorAction.kt b/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateConstructorAction.kt index 84f949cce..59ed9e787 100644 --- a/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateConstructorAction.kt +++ b/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateConstructorAction.kt @@ -26,11 +26,12 @@ import com.itsaky.androidide.actions.ActionData import com.itsaky.androidide.actions.requireFile import com.itsaky.androidide.actions.requirePath import com.itsaky.androidide.lsp.java.JavaCompilerProvider -import com.itsaky.androidide.resources.R.string import com.itsaky.androidide.lsp.java.actions.FieldBasedAction import com.itsaky.androidide.lsp.java.compiler.CompileTask import com.itsaky.androidide.lsp.java.utils.EditHelper +import com.itsaky.androidide.lsp.java.utils.ShortTypePrinter.NO_PACKAGE import com.itsaky.androidide.projects.ProjectManager +import com.itsaky.androidide.resources.R.string import com.itsaky.androidide.utils.ILogger import com.itsaky.toaster.Toaster.Type.ERROR import com.itsaky.toaster.toast @@ -147,7 +148,7 @@ class GenerateConstructorAction : FieldBasedAction() { val paramType = paramTypes[i] val paramName = paramNames[i] - constructor.addParameter(paramType.tsym.simpleName.toString(), paramName) + constructor.addParameter(NO_PACKAGE.print(paramType), paramName) } return constructor