From 50f059c2f6c344815d2e7c87ce0e6a8dce390210 Mon Sep 17 00:00:00 2001 From: Akash Yadav Date: Sat, 28 Oct 2023 15:43:29 +0530 Subject: [PATCH] fix(lsp/java): NPE while cancelling analyzing thread (fixes #1373) --- .../lsp/java/providers/JavaDiagnosticProvider.kt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/providers/JavaDiagnosticProvider.kt b/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/providers/JavaDiagnosticProvider.kt index d15bd6530..892782ebc 100644 --- a/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/providers/JavaDiagnosticProvider.kt +++ b/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/providers/JavaDiagnosticProvider.kt @@ -61,10 +61,12 @@ class JavaDiagnosticProvider { return cachedDiagnostics } - if (analyzing.get() && analyzingThread != null) { - log.debug("Cancelling currently analyzing thread...") - ProgressManager.instance.cancel(analyzingThread!!) - analyzingThread = null + analyzingThread?.let { analyzingThread -> + if (analyzing.get()) { + log.debug("Cancelling currently analyzing thread...") + ProgressManager.instance.cancel(analyzingThread) + this.analyzingThread = null + } } analyzing.set(true)