From 5aafb8eadac7402d43ceb5bd708483d2a77fa30c Mon Sep 17 00:00:00 2001 From: Akash Yadav Date: Sat, 23 Apr 2022 13:38:26 +0530 Subject: [PATCH] Added test case for JvmLogger --- build-tools/logger/build.gradle | 3 +++ .../java/com/itsaky/androidide/utils/JvmLogger.java | 12 +++++++----- .../com/itsaky/androidide/utils/LoggerTest.java | 13 +++++++++++++ 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/build-tools/logger/build.gradle b/build-tools/logger/build.gradle index b98f0d4d8..698fe3ebc 100644 --- a/build-tools/logger/build.gradle +++ b/build-tools/logger/build.gradle @@ -26,4 +26,7 @@ java { dependencies { compileOnly project(path: ':build-tools:framework-stubs') + + testImplementation tests.junit + testImplementation tests.google_truth } \ No newline at end of file diff --git a/build-tools/logger/src/main/java/com/itsaky/androidide/utils/JvmLogger.java b/build-tools/logger/src/main/java/com/itsaky/androidide/utils/JvmLogger.java index 01c7fb86b..33ecb5785 100644 --- a/build-tools/logger/src/main/java/com/itsaky/androidide/utils/JvmLogger.java +++ b/build-tools/logger/src/main/java/com/itsaky/androidide/utils/JvmLogger.java @@ -21,6 +21,7 @@ import java.io.PrintWriter; import java.io.StringWriter; import java.util.Date; import java.util.Locale; +import java.util.logging.ConsoleHandler; import java.util.logging.Formatter; import java.util.logging.Level; import java.util.logging.LogRecord; @@ -36,17 +37,18 @@ public class JvmLogger extends ILogger { private static final Logger LOG = Logger.getLogger("main"); static { - setRootFormat(); + initLogger(); } protected JvmLogger(String tag) { super(tag); } - private static void setRootFormat() { - var root = Logger.getLogger(""); - - for (var h : root.getHandlers()) { + private static void initLogger() { + LOG.addHandler(new ConsoleHandler()); + LOG.setLevel(Level.FINEST); + for (var h : LOG.getHandlers()) { + h.setLevel(Level.FINEST); h.setFormatter(new LogFormat()); } } diff --git a/build-tools/logger/src/test/java/com/itsaky/androidide/utils/LoggerTest.java b/build-tools/logger/src/test/java/com/itsaky/androidide/utils/LoggerTest.java index 81a766e2e..51b64283f 100644 --- a/build-tools/logger/src/test/java/com/itsaky/androidide/utils/LoggerTest.java +++ b/build-tools/logger/src/test/java/com/itsaky/androidide/utils/LoggerTest.java @@ -17,8 +17,21 @@ package com.itsaky.androidide.utils; +import static com.google.common.truth.Truth.assertThat; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + /** * @author Akash Yadav */ +@RunWith(JUnit4.class) public class LoggerTest { + @Test + public void testLoggerInstance() { + final var log = ILogger.newInstance("LoggerTest"); + log.debug ("Logger.newInstance() on JVM returns:", log.getClass().getName()); + assertThat(log).isInstanceOf(JvmLogger.class); + } }