From a311a1efbd96a986556a4a4aae0649b149cc03d7 Mon Sep 17 00:00:00 2001 From: Akash Yadav Date: Thu, 9 Nov 2023 01:41:44 +0530 Subject: [PATCH] build: do not fail if KEY_BIN is not set --- .../com/itsaky/androidide/plugins/util/SigningKeyUtils.kt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/build-logic/ide/src/main/java/com/itsaky/androidide/plugins/util/SigningKeyUtils.kt b/build-logic/ide/src/main/java/com/itsaky/androidide/plugins/util/SigningKeyUtils.kt index 306772353..5c7a69680 100644 --- a/build-logic/ide/src/main/java/com/itsaky/androidide/plugins/util/SigningKeyUtils.kt +++ b/build-logic/ide/src/main/java/com/itsaky/androidide/plugins/util/SigningKeyUtils.kt @@ -40,7 +40,7 @@ object SigningKeyUtils { return } - getEnvOrProp(KEY_BIN)?.let { bin -> + getEnvOrProp(key = KEY_BIN, warn = false)?.also { bin -> val contents = Base64.getDecoder().decode(bin) signingKey.writeBytes(contents) return @@ -62,14 +62,16 @@ object SigningKeyUtils { result.assertNormalExitValue() } - internal fun Project.getEnvOrProp(key: String): String? { + internal fun Project.getEnvOrProp(key: String, warn: Boolean = true): String? { var value: String? = System.getenv(key) if (value.isNullOrBlank()) { value = project.properties[key] as? String? } if (value.isNullOrBlank()) { - logger.warn("$key is not set. Debug key will be used to sign the APK") + if (warn) { + logger.warn("$key is not set. Debug key will be used to sign the APK") + } return null } return value