From c894d3d9d69e1fd11e7b76af794e1324587c0b8a Mon Sep 17 00:00:00 2001 From: Akash Yadav Date: Sat, 2 Mar 2024 20:50:01 +0530 Subject: [PATCH] fix: ignore completion requests when editor is not attached to window (fixes #1739) --- .../com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/editor/src/main/java/com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt b/editor/src/main/java/com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt index 38126eb75..3b2f898d9 100644 --- a/editor/src/main/java/com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt +++ b/editor/src/main/java/com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt @@ -27,7 +27,6 @@ import com.itsaky.androidide.utils.KeyboardUtils import io.github.rosemoe.sora.lang.completion.CompletionItem import io.github.rosemoe.sora.widget.component.CompletionLayout import io.github.rosemoe.sora.widget.component.EditorAutoCompletion -import io.github.rosemoe.sora.widget.getComponent import java.lang.ref.WeakReference import kotlin.math.min @@ -103,7 +102,7 @@ class EditorCompletionWindow(val editor: IDEEditor) : EditorAutoCompletion(edito } override fun requireCompletion() { - if (cancelShowUp || !isEnabled) { + if (cancelShowUp || !isEnabled || !editor.isAttachedToWindow) { return }