From de9655c43f1516821a3d2d88a686bdf7c68fa444 Mon Sep 17 00:00:00 2001 From: Akash Yadav Date: Sun, 26 Mar 2023 21:04:39 +0530 Subject: [PATCH] fix: log exception to IDE logs while executing code actions --- .idea/codeStyles/codeStyleConfig.xml | 2 +- .../androidide/lsp/java/actions/BaseJavaCodeAction.kt | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.idea/codeStyles/codeStyleConfig.xml b/.idea/codeStyles/codeStyleConfig.xml index 544f69660..7f6a23f53 100644 --- a/.idea/codeStyles/codeStyleConfig.xml +++ b/.idea/codeStyles/codeStyleConfig.xml @@ -1,5 +1,5 @@ - \ No newline at end of file diff --git a/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/BaseJavaCodeAction.kt b/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/BaseJavaCodeAction.kt index 5265d1950..8c18b0e21 100644 --- a/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/BaseJavaCodeAction.kt +++ b/lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/BaseJavaCodeAction.kt @@ -31,6 +31,7 @@ import com.itsaky.androidide.lsp.java.JavaLanguageServer import com.itsaky.androidide.lsp.java.rewrite.Rewrite import com.itsaky.androidide.projects.ProjectManager import com.itsaky.androidide.utils.DocumentUtils +import com.itsaky.androidide.utils.ILogger import com.itsaky.androidide.utils.flashError import java.io.File @@ -48,7 +49,6 @@ abstract class BaseJavaCodeAction : EditorActionItem { protected abstract val titleTextRes: Int override fun prepare(data: ActionData) { - if ( !data.hasRequiredData(Context::class.java, JavaLanguageServer::class.java, File::class.java) ) { @@ -76,10 +76,11 @@ abstract class BaseJavaCodeAction : EditorActionItem { val actions = try { result.asCodeActions(compiler, label) } catch (e: Exception) { - flashError(e.message) + flashError(e.cause?.message ?: e.message) + ILogger.instance().error(e) return } - + client.performCodeAction(file, actions) } }