From 14148a0ea4671224d3f22c3faf98b44c8d978e0e Mon Sep 17 00:00:00 2001 From: "opencode-agent[bot]" <219766164+opencode-agent[bot]@users.noreply.github.com> Date: Mon, 21 Sep 2026 12:37:19 +0800 Subject: [PATCH] fix(app): restore server status spacing (#50273) Co-authored-by: Brendonovich <14191578+Brendonovich@users.noreply.github.com> Co-authored-by: Kit Langton --- packages/app/e2e/regression/session-summary-layout.spec.ts | 6 ++++-- packages/app/e2e/regression/settings-loading.spec.ts | 2 +- packages/app/src/settings/settings.css | 4 ---- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/app/e2e/regression/session-summary-layout.spec.ts b/packages/app/e2e/regression/session-summary-layout.spec.ts index 26f9d3e27fa..404d95f2d57 100644 --- a/packages/app/e2e/regression/session-summary-layout.spec.ts +++ b/packages/app/e2e/regression/session-summary-layout.spec.ts @@ -71,7 +71,7 @@ for (const direction of ["ltr", "rtl"] as const) { const shifted = await content.evaluate((element) => getComputedStyle(element).translate) await content.evaluate((element) => element.setAttribute("data-summary-motion", "")) // Keep issuing resize events before the idle timer expires, including crossing the width cutoff. - for (const width of [1520, 1280, 1600]) { + for (const width of [1520, 1280, 1800]) { await page.setViewportSize({ width, height: 900 }) await expect(panel).toHaveAttribute("data-summary-resizing", "true") await page.clock.runFor(100) @@ -84,6 +84,7 @@ for (const direction of ["ltr", "rtl"] as const) { await expect(content).toHaveAttribute("data-summary-motion", "transitionrun,transitionend,") await expect(content).not.toHaveCSS("translate", shifted) await page.setViewportSize({ width: 1440, height: 900 }) + await expect(panel).toHaveAttribute("data-summary-resizing", "false") await expect(content).toHaveCSS("translate", shifted) await content.evaluate((element) => element.setAttribute("data-summary-motion", "")) @@ -112,7 +113,8 @@ for (const direction of ["ltr", "rtl"] as const) { await expect(summary).toBeVisible() await page.setViewportSize({ width: 1800, height: 900 }) - await expect(content).toHaveCSS("translate", "0px") + await expect(panel).toHaveAttribute("data-summary-resizing", "false") + await expect(content).toHaveCSS("translate", "none") await expect(summary).toBeVisible() await page.emulateMedia({ reducedMotion: "reduce" }) diff --git a/packages/app/e2e/regression/settings-loading.spec.ts b/packages/app/e2e/regression/settings-loading.spec.ts index fb9ef47ca39..8513fe172ed 100644 --- a/packages/app/e2e/regression/settings-loading.spec.ts +++ b/packages/app/e2e/regression/settings-loading.spec.ts @@ -116,7 +116,7 @@ test("single-server settings expose scoped pages without a server picker", async await expect(connection.getByRole("heading", { name: "Connection", exact: true })).toBeVisible() await expect(connection.locator('[data-component="settings-list"]')).toHaveCSS("padding-left", "16px") await expect(connection.locator(".settings-servers-row")).toHaveCSS("padding-top", "20px") - await expect(connection.locator(".settings-servers-lead")).toHaveCSS("column-gap", "4px") + await expect(connection.locator(".settings-servers-lead")).toHaveCSS("column-gap", "10px") await expect(connection.locator(".settings-servers-copy")).toHaveCSS("row-gap", "6px") await expect(settings.getByRole("heading", { name: "Preferences", exact: true })).toBeVisible() await expect(settings.getByText("Terminal shell", { exact: true })).toBeVisible() diff --git a/packages/app/src/settings/settings.css b/packages/app/src/settings/settings.css index cfbb7cb5f1b..c919fb00a63 100644 --- a/packages/app/src/settings/settings.css +++ b/packages/app/src/settings/settings.css @@ -1102,10 +1102,6 @@ padding-block: 20px; } -.settings-server-connection .settings-servers-lead { - gap: 4px; -} - .settings-servers-row:not(:last-child) { padding-bottom: 16px; margin-bottom: 16px;