Studio/AndroidIDE
5
0
Fork 0
mirror of https://gitee.com/zhangsken/AndroidIDE.git synced 2026-10-16 07:49:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(actions): make ActionItem visible and enabled by default

Browse Source
This commit is contained in:
Akash Yadav
2023-11-07 23:46:37 +05:30
parent 4fcf76848e
commit 7e64533302
24 changed files with 28 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
actions/src/main/java/com/itsaky/androidide/actions/ActionItem.kt
+6 -1
View File
@@ -23,6 +23,7 @@ import android.graphics.PorterDuffColorFilter
import android.graphics.drawable.Drawable
import android.view.Menu
import android.view.View
import androidx.annotation.CallSuper
import com.itsaky.androidide.utils.resolveAttr
/**
@@ -87,7 +88,11 @@ interface ActionItem {
*
* @param data The data containing various information about the event.
*/
fun prepare(data: ActionData)
@CallSuper
fun prepare(data: ActionData) {
visible = true
enabled = true
}
/**
* Execute the action. The action executed in a background thread by default.
actions/src/main/java/com/itsaky/androidide/actions/locations/CodeActionsMenu.kt
+1
View File
@@ -42,6 +42,7 @@ object CodeActionsMenu : ActionMenu {
override var location: ActionItem.Location = ActionItem.Location.EDITOR_TEXT_ACTIONS
override fun prepare(data: ActionData) {
super.prepare(data)
if (icon == null) {
icon = ContextCompat.getDrawable(data[Context::class.java]!!, R.drawable.ic_code)
}
app/src/main/java/com/itsaky/androidide/actions/BaseBuildAction.kt
+1
View File
@@ -33,6 +33,7 @@ abstract class BaseBuildAction : EditorActivityAction() {
get() = Lookup.getDefault().lookup(BuildService.KEY_BUILD_SERVICE)
override fun prepare(data: ActionData) {
super.prepare(data)
val context = data.getActivity()
if (context == null) {
visible = false
app/src/main/java/com/itsaky/androidide/actions/BaseEditorAction.kt
+1
View File
@@ -33,6 +33,7 @@ abstract class BaseEditorAction : EditorActionItem {
override var location: ActionItem.Location = ActionItem.Location.EDITOR_TEXT_ACTIONS
override fun prepare(data: ActionData) {
super.prepare(data)
getEditor(data)
?: kotlin.run {
visible = false
app/src/main/java/com/itsaky/androidide/actions/EditorActivityAction.kt
+1
View File
@@ -41,6 +41,7 @@ abstract class EditorActivityAction : ActionItem {
CoroutineName("${javaClass.simpleName}Scope")
override fun prepare(data: ActionData) {
super.prepare(data)
if (!data.hasRequiredData(Context::class.java)) {
markInvisible()
}
app/src/main/java/com/itsaky/androidide/actions/EditorRelatedAction.kt
+2
View File
@@ -26,6 +26,8 @@ abstract class EditorRelatedAction : EditorActivityAction(), EditorActionItem {
override var requiresUIThread: Boolean = true
override fun prepare(data: ActionData) {
super<EditorActionItem>.prepare(data)
super<EditorActivityAction>.prepare(data)
val editor =
data.getEditor()
?: run {
app/src/main/java/com/itsaky/androidide/actions/build/QuickRunWithCancellationAction.kt
+1 -1
View File
@@ -67,7 +67,7 @@ class QuickRunWithCancellationAction(context: Context, override val order: Int)
override var requiresUIThread: Boolean = true
override fun prepare(data: ActionData) {
super.prepare(data)
val context = data.getActivity() ?: run {
markInvisible()
return
app/src/main/java/com/itsaky/androidide/actions/editor/LongSelectAction.kt
+1
View File
@@ -41,6 +41,7 @@ class LongSelectAction(context: Context, override val order: Int) : EditorRelate
}
override fun prepare(data: ActionData) {
super.prepare(data)
data.getEditor() ?: markInvisible()
}
app/src/main/java/com/itsaky/androidide/actions/etc/DisconnectLogSendersAction.kt
+1
View File
@@ -40,6 +40,7 @@ class DisconnectLogSendersAction(context: Context, override val order: Int) : Ed
}
override fun prepare(data: ActionData) {
super.prepare(data)
data.getActivity() ?: run {
markInvisible()
return
app/src/main/java/com/itsaky/androidide/actions/etc/FileTreeAction.kt
-5
View File
@@ -36,11 +36,6 @@ class FileTreeAction(context: Context, override val order: Int) : EditorActivity
icon = ContextCompat.getDrawable(context, R.drawable.ic_folder)
}
override fun prepare(data: ActionData) {
visible = true
enabled = true
}
override suspend fun execAction(data: ActionData): Boolean {
val context = data.getActivity() ?: return false
app/src/main/java/com/itsaky/androidide/actions/etc/FindActionMenu.kt
+2
View File
@@ -40,6 +40,8 @@ class FindActionMenu(context: Context, override val order: Int) : EditorActivity
}
override fun prepare(data: ActionData) {
super<ActionMenu>.prepare(data)
super<EditorActivityAction>.prepare(data)
visible = true
enabled = children.size > 0
}
app/src/main/java/com/itsaky/androidide/actions/etc/FindInProjectAction.kt
+1
View File
@@ -40,6 +40,7 @@ class FindInProjectAction() : EditorActivityAction() {
override val id: String = "ide.editor.find.inProject"
override fun prepare(data: ActionData) {
super.prepare(data)
data.getActivity()
?: run {
markInvisible()
app/src/main/java/com/itsaky/androidide/actions/etc/LaunchAppAction.kt
+1
View File
@@ -47,6 +47,7 @@ class LaunchAppAction(context: Context, override val order: Int) : EditorActivit
}
override fun prepare(data: ActionData) {
super.prepare(data)
data.getActivity() ?: run {
markInvisible()
return
app/src/main/java/com/itsaky/androidide/actions/file/SaveFileAction.kt
+1 -1
View File
@@ -44,7 +44,7 @@ class SaveFileAction(context: Context, override val order: Int) : EditorRelatedA
}
override fun prepare(data: ActionData) {
super.prepare(data)
val context =
data.getActivity()
?: run {
app/src/main/java/com/itsaky/androidide/actions/filetree/BaseDirNodeAction.kt
+1
View File
@@ -34,6 +34,7 @@ abstract class BaseDirNodeAction(context: Context,
@DrawableRes iconRes: Int? = null) : BaseFileTreeAction(context, labelRes, iconRes) {
override fun prepare(data: ActionData) {
super.prepare(data)
if (!data.hasFileTreeData()) {
markInvisible()
return
app/src/main/java/com/itsaky/androidide/actions/filetree/BaseFileTreeAction.kt
+1
View File
@@ -53,6 +53,7 @@ abstract class BaseFileTreeAction(
}
override fun prepare(data: ActionData) {
super.prepare(data)
if (!data.hasFileTreeData()) {
markInvisible()
return
app/src/main/java/com/itsaky/androidide/actions/sidebar/AbstractSidebarAction.kt
-5
View File
@@ -18,7 +18,6 @@
package com.itsaky.androidide.actions.sidebar
import android.graphics.drawable.Drawable
import android.view.Menu
import com.itsaky.androidide.actions.ActionData
import com.itsaky.androidide.actions.ActionItem
import com.itsaky.androidide.actions.SidebarActionItem
@@ -41,10 +40,6 @@ abstract class AbstractSidebarAction : SidebarActionItem {
override var icon: Drawable? = null
override var label: String = ""
// should not be needed
override fun prepare(data: ActionData) {
}
override suspend fun execAction(data: ActionData): Any {
return false
}
lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/BaseJavaCodeAction.kt
+1
View File
@@ -54,6 +54,7 @@ abstract class BaseJavaCodeAction : EditorActionItem {
protected abstract val titleTextRes: Int
override fun prepare(data: ActionData) {
super.prepare(data)
if (
!data.hasRequiredData(Context::class.java, JavaLanguageServer::class.java, File::class.java)
) {
lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/diagnostics/VariableToStatementAction.kt
-1
View File
@@ -39,7 +39,6 @@ class VariableToStatementAction : BaseJavaCodeAction() {
override val titleTextRes: Int = R.string.action_convert_to_statement
@Suppress("UNCHECKED_CAST")
override fun prepare(data: ActionData) {
super.prepare(data)
uidesigner/src/main/java/com/itsaky/androidide/uidesigner/actions/RedoAction.kt
+1
View File
@@ -37,6 +37,7 @@ class RedoAction(context: Context) : UiDesignerAction() {
}
override fun prepare(data: ActionData) {
super.prepare(data)
visible = true
enabled = data.requireWorkspace().undoManager.canRedo()
}
uidesigner/src/main/java/com/itsaky/androidide/uidesigner/actions/ShowHierarchyAction.kt
+1
View File
@@ -41,6 +41,7 @@ class ShowHierarchyAction(context: Context) : UiDesignerAction() {
}
override fun prepare(data: ActionData) {
super.prepare(data)
if (!data.hasRequiredData(Context::class.java, Fragment::class.java)) {
markInvisible()
return
uidesigner/src/main/java/com/itsaky/androidide/uidesigner/actions/ShowXmlAction.kt
+1
View File
@@ -47,6 +47,7 @@ class ShowXmlAction(context: Context) : UiDesignerAction() {
}
override fun prepare(data: ActionData) {
super.prepare(data)
if (!data.hasRequiredData(Context::class.java, Fragment::class.java)) {
markInvisible()
return
uidesigner/src/main/java/com/itsaky/androidide/uidesigner/actions/UiDesignerAction.kt
+1
View File
@@ -44,6 +44,7 @@ abstract class UiDesignerAction : ActionItem {
override var visible: Boolean = true
override fun prepare(data: ActionData) {
super.prepare(data)
if (!data.hasRequiredData(Context::class.java, Fragment::class.java)) {
markInvisible()
return
uidesigner/src/main/java/com/itsaky/androidide/uidesigner/actions/UndoAction.kt
+1
View File
@@ -38,6 +38,7 @@ class UndoAction(context: Context) : UiDesignerAction() {
}
override fun prepare(data: ActionData) {
super.prepare(data)
visible = true
enabled = data.requireWorkspace().undoManager.canUndo()
}